Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): add PopStateEvent interface #13400

Closed
wants to merge 1 commit into from
Closed

fix(common): add PopStateEvent interface #13400

wants to merge 1 commit into from

Conversation

DzmitryShylovich
Copy link
Contributor

Closes #13378

@vicb vicb added area: common Issues related to APIs in the @angular/common package feature Issue that requests a new feature labels Dec 12, 2016
@mhevery
Copy link
Contributor

mhevery commented Jan 28, 2017

Tests please

@DzmitryShylovich
Copy link
Contributor Author

@mhevery I just added an interface instead of any. Not sure how I can test it.

@mhevery
Copy link
Contributor

mhevery commented Jan 31, 2017

I see, sounds good.

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Jan 31, 2017
@mhevery mhevery closed this in fe44118 Jan 31, 2017
@DzmitryShylovich DzmitryShylovich deleted the gh/13378 branch January 31, 2017 23:14
mhevery pushed a commit that referenced this pull request Feb 2, 2017
@mhevery
fix(common): add PopStateEvent interface (#13400)
e740bff 
Closes #13378

PR Close #13400
mhevery pushed a commit that referenced this pull request Feb 3, 2017
@mhevery
fix(common): add PopStateEvent interface (#13400)
5651766 
Closes #13378

PR Close #13400
mhevery pushed a commit to mhevery/angular that referenced this pull request Feb 3, 2017
@mhevery
fix(common): add PopStateEvent interface (angular#13400)
71567d1 
Closes angular#13378

PR Close angular#13400
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
fix(common): add PopStateEvent interface (angular#13400)
84285f0 
Closes angular#13378

PR Close angular#13400
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@juleskremer
fix(common): add PopStateEvent interface (angular#13400)
9d8f16b 
Closes angular#13378

PR Close angular#13400
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cla: yes feature Issue that requests a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

location subscribe returns an object instead of "real" interface
4 participants
@DzmitryShylovich @mhevery @vicb @googlebot